Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid running blocking code during *summarize_plan()* #90

Closed
prjemian opened this issue Feb 14, 2019 · 4 comments
Closed

avoid running blocking code during *summarize_plan()* #90

prjemian opened this issue Feb 14, 2019 · 4 comments
Assignees
@prjemian
Labels
maintenance
Milestone
milestone-1.1.0

Comments

@prjemian
Copy link
Contributor

Inplans.run_blocker_in_plan() there is a FIXME comment about how to avoid running blocking code during summarize_plan().
@prjemian prjemian added this to the release in May 2019 milestone Feb 14, 2019
@prjemian prjemian self-assigned this Feb 14, 2019
@prjemian
Copy link
Contributor Author

Yet still a great way to avoid running blocking code in bluesky plans is to not use it. Test frequently while developing.

@prjemian
Copy link
Contributor Author

Moving to later milestone.

@prjemian
Copy link
Contributor Author

Looking through code for summarize_plan, the answer is the current code does not provide a means to enable this idea.

So, don't write blocking code in plans. Period.

@prjemian
Copy link
Contributor Author

prjemian commented Jul 3, 2019

Mark run_blocker_in_plan as Deprecated. Will remove by 2019-12-31.

prjemian added a commit that referenced this issue Jul 3, 2019
@prjemian
DOC #90. Deprecate now. Mark for future removal.
9b6a2cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
maintenance
Projects
None yet
Milestone
milestone-1.1.0
Development

No branches or pull requests
1 participant
@prjemian