Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only subscribe with event_type="setpoint" when it is available #1034

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the bug label Oct 29, 2024
@prjemian prjemian added this to the 1.7.2 milestone Oct 29, 2024
@prjemian prjemian self-assigned this Oct 29, 2024
Copy link
Collaborator

@canismarko canismarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this against the latest Haven version and all my tests pass. Changes look good. Thanks.

Copy link
Collaborator

@gfabbris gfabbris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@prjemian prjemian merged commit e9780ed into main Nov 20, 2024
8 of 10 checks passed
@prjemian prjemian deleted the 1022-subscription-with-fake branch November 20, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PVPositionerSoftDone uses invalid subscription event type for simulated devices
4 participants