Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhaul of listruns() using pandas #504

Merged
merged 7 commits into from
Mar 24, 2021
Merged

overhaul of listruns() using pandas #504

merged 7 commits into from
Mar 24, 2021

Conversation

prjemian
Copy link
Contributor

fix #500

Thanks to @strempfer, @rodolakis, and John Freeland for the suggestions!

@prjemian prjemian added this to the 1.5.0 milestone Mar 22, 2021
@prjemian prjemian self-assigned this Mar 22, 2021
@prjemian
Copy link
Contributor Author

CI is failing for py3.6 with E ModuleNotFoundError: No module named 'dataclasses'. That's because that was added in py3.7. Time to drop py3.6.

@prjemian prjemian requested a review from gfabbris March 22, 2021 22:27
Copy link
Collaborator

@gfabbris gfabbris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

apstools/utils.py Outdated Show resolved Hide resolved
apstools/utils.py Show resolved Hide resolved
apstools/utils.py Show resolved Hide resolved
@prjemian prjemian merged commit f546649 into main Mar 24, 2021
@prjemian prjemian deleted the 500-ListRuns-class branch March 24, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listruns() sort: improvements
2 participants