Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break devices module into submodule _devices #539

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Break devices module into submodule _devices #539

merged 7 commits into from
Sep 28, 2021

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the task Something to be done. label Sep 27, 2021
@prjemian prjemian added this to the 1.5.2 milestone Sep 27, 2021
@prjemian prjemian self-assigned this Sep 27, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2021

This pull request introduces 13 alerts when merging 828b588 into 63deaf1 - view on LGTM.com

new alerts:

  • 13 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2021

This pull request introduces 36 alerts and fixes 2 when merging c11fa3f into 63deaf1 - view on LGTM.com

new alerts:

  • 34 for Unused import
  • 2 for Missing call to `__init__` during object initialization

fixed alerts:

  • 2 for Missing call to `__init__` during object initialization

@prjemian prjemian merged commit 9a9f359 into main Sep 28, 2021
@prjemian prjemian deleted the 538_devices branch September 28, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@prjemian prjemian

Labels
task Something to be done.
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.

allow for _devices submodule
1 participant
@prjemian