Added try...except for unconnected components when using apstools.uti… #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@canismarko Thanks for the PR. I'll take a look at this later today and add tests. We would benefit from running containers but our IT group says no to docker, particularly. They've got their reasons. For now, we'll rely on the GitHub Actions to run our CI, our run docker on non-company hardware, as I do now. |
prjemian
added a commit
that referenced
this pull request
May 23, 2023
prjemian
added a commit
that referenced
this pull request
May 23, 2023
prjemian
added a commit
that referenced
this pull request
May 23, 2023
prjemian
added a commit
that referenced
this pull request
May 23, 2023
|
While, later, adding test cases, found additional lines to change. |
|
New PR for those changes and tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #845
I didn't write a test for it because I couldn't get the test IOCs to run: I don't have docker installed on this computer and it's not in the RHEL8 repositories. If you need tests, let me know and I'll ask AES-IT about getting docker on this machine.