Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shutter tests and make PSS shutter more flexible #857

Merged
merged 13 commits into from
May 18, 2023
Merged

add shutter tests and make PSS shutter more flexible #857

merged 13 commits into from
May 18, 2023

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added this to the 1.6.16 milestone May 17, 2023
@prjemian prjemian self-assigned this May 17, 2023
@prjemian prjemian requested review from gfabbris and canismarko May 17, 2023 16:14
@prjemian
Copy link
Contributor Author

@canismarko @gfabbris : Added backwards-compatible flexibility for the OPEN and CLOSE PV names used by ApsPssShutter & ApsPssShutterWithStatus.

Please review if you have time.

@prjemian
Copy link
Contributor Author

Note: Some of the classes in shutters.py do not have documentation for the list of parameters. That needs to be added.

@prjemian
Copy link
Contributor Author

Ready for review. I'd like to merge early next week if there are no objections.

@prjemian prjemian merged commit 6cc78b6 into main May 18, 2023
@prjemian prjemian deleted the 838-PSS-shutter branch May 18, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfabbris gfabbris gfabbris approved these changes

@canismarko canismarko canismarko approved these changes

Assignees

@prjemian prjemian

Labels
enhancement testing
Projects
None yet
Milestone
1.6.16
Development

Successfully merging this pull request may close these issues.

Make PSS Shutter devices more flexible for different beamlines
3 participants
@prjemian @canismarko @gfabbris