Support for LabJack DAQ devices #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not yet support the waveform digitizer or waveform generator, or the other LabJack T7 models.
prjemian
reviewed
Jan 1, 2024
prjemian
reviewed
Jan 1, 2024
prjemian
reviewed
Jan 1, 2024
prjemian
reviewed
Jan 1, 2024
prjemian
reviewed
Jan 1, 2024
prjemian
reviewed
Jan 1, 2024
prjemian
reviewed
Jan 1, 2024
apstools/devices/labjack.py
Outdated
| class AnalogOutput(Output): | ||
| """An analog output on a labjack device.""" | ||
|
|
||
| pass |
prjemian
reviewed
Jan 1, 2024
prjemian
reviewed
Jan 1, 2024
prjemian
reviewed
Jan 1, 2024
prjemian
requested changes
Jan 1, 2024
Co-authored-by: Pete R Jemian <prjemian@users.noreply.github.com>
Co-authored-by: Pete R Jemian <prjemian@users.noreply.github.com>
canismarko
commented
Jan 2, 2024
prjemian
approved these changes
Jan 2, 2024
|
@canismarko: If you can, push the green merge button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #879.
One note: I created a LabJackBase class and then subclass this for the various T-series devices (e.g. LabJackT4). Makes the code easy to maintain, but docstring don't seem to be inheriting properly on the sphinx autoapi.