example scans with sscan record #942
Conversation
prjemian
commented
Mar 17, 2024
prjemian
commented
- close New example: scaler v. motor using sscan record #940
docs/source/examples/de_sscan.ipynb
Outdated
| "\n", | ||
| "So far, we have just run `scan1` and shown the data collected. We'll need to do\n", | ||
| "a bit more work to get this data into bluesky as a run. While we might just use\n", | ||
| "`bps.read(scan1)` to get the data, the data would be named according to the\n", |
docs/source/examples/de_sscan.ipynb
Outdated
| "`scan1` structure. We want more meaningful names so we re-assign the names of\n", | ||
| "the original objects (motor and scaler channel names). To post *bluesky data*,\n", | ||
| "it must come from an ophyd `Device` (subclass). We'll create a custom one just\n", | ||
| "for our setup of `scan1`, then `bps.mv()` each of the arrays. Since we do not\n", |
There was a problem hiding this comment.
I do not understand this "then bps.mv() each of the arrays", is it missing a word?
| "from ophyd import Component, Device, Signal\n", | ||
| "\n", | ||
| "class ThisSscanData(Device):\n", | ||
| " m1 = Component(Signal)\n", |
There was a problem hiding this comment.
An ophyd structure. Do not want to repeat this here (it must be explained somewhere else). Should we find and reference the documentation page?
There was a problem hiding this comment.
I looked at the documentation page but it did not help. Maybe there are better reference.
There was a problem hiding this comment.
Component is a tool used by ophyd's Device to mark an attribute as an ophyd object that needs to be handled either as a Device or a Signal. The first argument tells which type of ophyd (or custom) class to be used.
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", |
There was a problem hiding this comment.
I am lost from "so far" to here.
There was a problem hiding this comment.
I added various changes with the latest commit. Did not resolve any conversations. Please see if some of your questions have been resolved.
There was a problem hiding this comment.
Might take more discussion for us. After tomorrow's discussion?
|
We need to make our documentation more modular so we do not repeat the explanation of similar concepts, such as:
|
| "from ophyd import Component, Device, Signal\n", | ||
| "\n", | ||
| "class ThisSscanData(Device):\n", | ||
| " m1 = Component(Signal)\n", |
There was a problem hiding this comment.
I looked at the documentation page but it did not help. Maybe there are better reference.
|
Still working on it, was just having some problem between 2 pages of comment open. So hold on to reply! |
| "from ophyd import Component, Device, Signal\n", | ||
| "\n", | ||
| "class ThisSscanData(Device):\n", | ||
| " m1 = Component(Signal)\n", |
There was a problem hiding this comment.
Component is a tool used by ophyd's Device to mark an attribute as an ophyd object that needs to be handled either as a Device or a Signal. The first argument tells which type of ophyd (or custom) class to be used.
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", |
There was a problem hiding this comment.
Might take more discussion for us. After tomorrow's discussion?
|
I am all good up to section 4. I will need help after that. If you want to merge go for it, and/or we can discuss tomorrow. I do have a pretty full day though. Otherwise Wednesday morning during our weekly meeting? |
