-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge align Function created #943
Conversation
MDecarabas
commented
Mar 18, 2024
- Created a function that allows for aligning beam with edge
- Close Can lineup2() identify a leading or following edge? #935
Note that CI fails on the
|
Will we able to get this resolved and merged in the next week? I'd like to publish the 1.6.19 release next Friday (April 12). Or, could move it to next milestone. |
We can definitely make that happen. |
@MDecarabas I'm looking for changes that consider the covariance matrix from the fit as a means to validate if the desired feature has been found. |
Still some merge conflicts to resolve. |
Drop in code coverage is understandable. Unit testing would improve that score. (Good for the future.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thought I saw merge conflicts, now there are none, waiting on the tests to run... |
Yep, there were. But I fixed them right when I saw them |