Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the home page friendlier #956

Merged
merged 15 commits into from
Apr 10, 2024
Merged

Make the home page friendlier #956

merged 15 commits into from
Apr 10, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Apr 5, 2024

@prjemian prjemian added this to the 1.6.19 milestone Apr 5, 2024
@prjemian prjemian self-assigned this Apr 5, 2024
@prjemian
Copy link
Contributor Author

prjemian commented Apr 5, 2024

image

@prjemian
Copy link
Contributor Author

prjemian commented Apr 5, 2024

Consider combining Overview and home pages.

@prjemian
Copy link
Contributor Author

prjemian commented Apr 6, 2024

Ready for review. Since the docs workflow does not upload a ZIP of the built docs (yet), I published to the development channel: https://bcda-aps.github.io/apstools/dev/index.html

@prjemian prjemian marked this pull request as draft April 6, 2024 22:52
@prjemian prjemian marked this pull request as ready for review April 6, 2024 23:01
@prjemian
Copy link
Contributor Author

prjemian commented Apr 6, 2024

Now uploads docs built during workflow run.

@rodolakis
Copy link
Collaborator

That may be a bit stupid but the fact that Introduction does not follow the pattern of the other section confused me a bit: no introduction page, therefor section title not hyperlink and navigation bar does not quite match home page content.

@prjemian
Copy link
Contributor Author

prjemian commented Apr 8, 2024

The Introduction card is odd. Did not want to create a new intro page just for this simple content. #957 will help, perhaps that should happen here? Then, this card will be swapped out with content from the Overview page.

@prjemian
Copy link
Contributor Author

prjemian commented Apr 8, 2024

@rodolakis How about this revision?

@prjemian
Copy link
Contributor Author

Reviewed with @rodolakis this morning.

@prjemian prjemian merged commit 14060fd into main Apr 10, 2024
13 of 14 checks passed
@prjemian prjemian deleted the 955-safer-home branch April 10, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider combining Overview and home pages. Make the home page friendlier
2 participants