Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesh_grid feature for 8-ID #958

Merged
merged 10 commits into from
Apr 12, 2024
Merged

mesh_grid feature for 8-ID #958

merged 10 commits into from
Apr 12, 2024

Conversation

MDecarabas
Copy link
Collaborator

No description provided.

@MDecarabas MDecarabas added this to the 1.6.19 milestone Apr 8, 2024
@MDecarabas MDecarabas requested a review from prjemian April 8, 2024 19:46
@MDecarabas MDecarabas self-assigned this Apr 8, 2024
prjemian
prjemian reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things to examine. On second thought, the logger.warning() for missing hints might be unwelcome.

@prjemian
Copy link
Contributor

Can you finish this today?

@prjemian
Copy link
Contributor

One more addition:

apstools/environment.yml

Line 36 in ccecf2f

- sphinx >=5

After this line, add:

 - toolz

prjemian
prjemian approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Assume the pin on toolz is needed. Could synchronize same pinning in both pyproject.toml and environment.yml. Not a blocker, though.

@MDecarabas MDecarabas merged commit 5301e19 into main Apr 12, 2024
13 checks passed
@MDecarabas MDecarabas deleted the xpcs_mesh branch April 12, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prjemian prjemian prjemian approved these changes

@rodolakis rodolakis Awaiting requested review from rodolakis

Assignees

@MDecarabas MDecarabas

Labels
enhancement
Projects
None yet
Milestone
1.6.19
Development

Successfully merging this pull request may close these issues.
2 participants
@MDecarabas @prjemian