update APS operating cycle info #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prjemian
commented
Jul 1, 2024
prjemian
commented
- close aps_cycle_info.yml #971
- aps_cycle.py #970 (necessary revisions were not caught in this PR)
MDecarabas
approved these changes
Jul 1, 2024
apstools/devices/aps_cycle.py
Outdated
Comment on lines
112
to
114
| from dm import ApsDbApiFactory | ||
| from dm.common.exceptions.dmException import DmException | ||
| from ..utils.aps_data_management import dm_source_environ |
There was a problem hiding this comment.
does dm not get used elsewhere?
There was a problem hiding this comment.
Yes. But what is the concern here?
There was a problem hiding this comment.
This is another example where the import of dm is encapsulated in this specific method. As in other modules of apstools, it is entirely possible that a user should be able to import this module on systems where dm is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.