Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RevolverInsertionDevice #995

Merged
merged 2 commits into from
Jul 2, 2024
Merged

add RevolverInsertionDevice #995

merged 2 commits into from
Jul 2, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Jul 1, 2024

@prjemian prjemian added this to the 1.6.20 milestone Jul 1, 2024
@prjemian prjemian self-assigned this Jul 1, 2024
@prjemian
Copy link
Contributor Author

prjemian commented Jul 1, 2024

@canismarko - I refactored the PlanarUndulator into mixin classes so they could be re-used.

@prjemian prjemian merged commit 0bf79b9 into main Jul 2, 2024
13 checks passed
@prjemian prjemian deleted the 979-revolver-insertion-device branch July 2, 2024 15:50
@canismarko
Copy link
Collaborator

I refactored the PlanarUndulator into mixin classes so they could be re-used.

Bit late to the party, but that makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDecarabas MDecarabas MDecarabas approved these changes

@canismarko canismarko Awaiting requested review from canismarko

Assignees

@prjemian prjemian

Labels
maintenance
Projects
No open projects
apstools 1.6.20 project
Status: Done
Milestone
1.6.20
Development

Successfully merging this pull request may close these issues.

Revolver insertion device (only 08US, 08DS, 34DS)
3 participants
@prjemian @canismarko @MDecarabas