Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Adding data source for device type + Fixing typo in model names #36

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Feat: Adding data source for device type + Fixing typo in model names #36

merged 7 commits into from
Jul 18, 2023

Conversation

OrKarstoft
Copy link
Contributor

@OrKarstoft OrKarstoft commented Jul 17, 2023 •
edited
Loading

Changes

  • Added data source for NetBox device type and includes custom fields.
  • Fixed typos on model names.
  • Fixed deprecated ioutil with io.
  • Fixed unnecessary use of fmt.Sprintf.

@OrKarstoft OrKarstoft changed the title Feat: Adding data source for device type Feat: Adding data source for device type + Fixing typo in model names Jul 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@OrKarstoft OrKarstoft marked this pull request as ready for review July 17, 2023 15:02
@OrKarstoft OrKarstoft requested a review from a team as a code owner July 17, 2023 15:02
brondum
brondum approved these changes Jul 18, 2023
View reviewed changes
Copy link

@brondum brondum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Oliver :)

@OrKarstoft OrKarstoft merged commit 1c5e4e6 into master Jul 18, 2023
@OrKarstoft OrKarstoft deleted the adding-data-device-type branch July 18, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrei-Predoiu Andrei-Predoiu Andrei-Predoiu approved these changes

@brondum brondum brondum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OrKarstoft @Andrei-Predoiu @brondum