Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim text editor to the container #60

Merged
merged 2 commits into from
May 9, 2024
Merged

Add vim text editor to the container #60

merged 2 commits into from
May 9, 2024

Conversation

rahmans1
Copy link
Contributor

@rahmans1 rahmans1 commented May 9, 2024

Add a light weight text editor to the container. Just chose vim because that's what I am used to.

Resolves #59

@rahmans1 rahmans1 requested a review from plexoos May 9, 2024 15:02
@buddhasystem
Copy link

Ouch! vim! :)
Do we already have nano, at least?

@plexoos
Copy link
Member

plexoos commented May 9, 2024

An editor can be installed... But I don't think that is customary to do so. Look at the various images distributed by major companies, they don't include editors or any additional tools beyond the main application . I guess when people use containers they usually assume a different workflow (although you can install whatever you want when you run it as root).

In our case when we run esi-shell the $HOME dir is mounted inside the container by default. Can we use editors installed on the host to modify files in the user HOME, so the changes are also visible within the container?

@plexoos
Copy link
Member

plexoos commented May 9, 2024

Anyway, that said, it makes a bit more sense to install external tools with the system package manager rather than spack.
I would like to reserve the spack environment for only direct dependencies to our primary applications.
See next commit

@plexoos plexoos merged commit 7a0e1f9 into beta May 9, 2024
1 check passed
@plexoos plexoos deleted the add-vim-text-editor branch May 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text editor to use within esi-shell
3 participants