Misses -lz for client to compile

[smoe]

The error was

/miniconda2/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: boinc_client-async_file.o: undefined reference to symbol 'gzclose'
/miniconda2/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: /users/sm718/miniconda2/lib/./libz.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:706: boinc_client] Error 1
make[2]: Leaving directory '/ngs/sm718/github/boinc/client'
make[1]: *** [Makefile:635: all-recursive] Error 1
make[1]: Leaving directory '/ngs/sm718/github/boinc'
make: *** [Makefile:538: all] Error 2

Circumvented with

diff --git a/client/Makefile.am b/client/Makefile.am
index f39c45fe60..41cdbaf200 100644
--- a/client/Makefile.am
+++ b/client/Makefile.am
@@ -109,7 +109,7 @@ else
 boinc_client_SOURCES += hostinfo_unix.cpp
 endif
 endif
-boinc_client_LDADD = $(LIBBOINC) $(LIBBOINC_CRYPT) $(BOINC_EXTRA_LIBS) $(PTHREAD_LIBS)
+boinc_client_LDADD = $(LIBBOINC) $(LIBBOINC_CRYPT) $(BOINC_EXTRA_LIBS) $(PTHREAD_LIBS) -lz

 boinc_clientdir = $(bindir)

Configuration was

./configure --prefix=$HOME/boinc --enable-client --disable-server --disable-manager --enable-libraries --enable-boinczip --disable-apps --with-ssl=/miniconda2/

[AenBleidd]

If not using miniconda2 in favor of openssl, no additional flag required. Adding -lz flag in default configuration will add extra dependency that is not nice. If you want to fix this issue and make a pull request please find a way to add check for miniconda2 and adding the corresponding linking flag to appropriate m4 file

[smoe]

I fail to understand why this omitted -lz could be caused by conda. I accredited it to --enable-boinczip . I don't want to create a pull request just now and propose to leave this report open for a while to collect more opinions/observations.

[AenBleidd]

As per this build log everything works fine without any additional -lz flag. So I suspect it is really because of conda library.
@smoe, could you please verify this?

[smoe]

Since I am the only one with weird experiences I suggest to just close this issue. What should possibly think about, though, is to provide a conda package for the client. This should then also clarify what this -lz is all about.

[tmannerm]

The -lz flag is already required (and normally used) to build a BOINC Client due to async_file.cpp and some other files referencing gzopen(), gzclose() and gzread() unconditionally. The flag comes into client build via BOINC_EXTRA_LIBS variable generated at configure.ac line 513.

One reason that could fail is if your compiler can't build a simple program using gzopen() with -lz flag. I'd look for line checking for gzopen in static library z... -lz line in your config output. Other configure output files like it's log and status can be consulted for more information as well.

[SETIguy]

config.log should show some additional detail.

…

On Tue, Jul 30, 2019 at 9:04 AM Teemu Mannermaa ***@***.***> wrote: The -lz flag is already required (and normally used) to build a BOINC Client due to async_file.cpp <https://github.com/BOINC/boinc/blob/master/client/async_file.cpp#L208> and some other files referencing gzopen(), gzclose() and gzread() unconditionally. The flag comes into client build via BOINC_EXTRA_LIBS variable generated at configure.ac line 513 <https://github.com/BOINC/boinc/blob/master/configure.ac#L513>. One reason that could fail is if your compiler can't build a simple program using gzopen() with -lz flag. I'd look for line checking for gzopen in static library z... -lz line in your config output. Other configure output files like it's log and status can be consulted for more information as well. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3205?email_source=notifications&email_token=ACS5ZMWXT5JMZWTI6ZCCXELQCBRBZA5CNFSM4H43PQGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3EPAVA#issuecomment-516485204>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACS5ZMRVSORAGIRGGQE4LODQCBRBZANCNFSM4H43PQGA> .

-- Eric Korpela korpela@ssl.berkeley.edu AST:7731^29u18e3

[AenBleidd]

@smoe, any updated on this?

[smoe]

I don't have the time to reinvestigate, I must admit. You don't mind me closing the issue for now, I presume. Thank you tons for your comments which will certainly help to get a better error report by whoever runs next into this (non?)issue.