Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC am_set_info.php does not return success correctly #3297

Closed
drshawnkwang opened this issue Sep 20, 2019 · 0 comments · Fixed by #3298
Closed

RPC am_set_info.php does not return success correctly #3297

drshawnkwang opened this issue Sep 20, 2019 · 0 comments · Fixed by #3298

Comments

@drshawnkwang
Copy link
Contributor

drshawnkwang commented Sep 20, 2019

Describe the bug
There is an extra success() function being called by am_set_info.php, line 239

Steps To Reproduce

  1. Send a Web RPC command to am_set_info.php such as https://PROJECT_URL/am_set_info.php?account_key=abc&show_hosts=0

Expected behavior
The code should return:

<am_set_info_reply>
<success/>
</am_set_info_reply>

System Information (please complete the following information):

  • BOINC Server Version: since 2018

Additional context
I believe the correct solution is to remove the success() function on line 239. There is success call at the bottom (L270) that should be called instead. If there are errors, there are xml_error() function calls.

The E@H Drupal web code breaks because of this bug. And should be fixed in upstream Web code. I'll create a PR for this soon.

@drshawnkwang drshawnkwang changed the title am_set_info.php does not return success correctly RPC am_set_info.php does not return success correctly Sep 20, 2019
Rytiss added a commit that referenced this issue Sep 20, 2019
success() call was duplicated, resulting in duplicate XML.

Fixes #3297
@AenBleidd AenBleidd added this to the Server Release 1.4.1 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants