Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manager]: fix minor graphics bug in #5010 #5019

Closed
RichardHaselgrove opened this issue Nov 18, 2022 · 3 comments · Fixed by #5022
Closed

[Manager]: fix minor graphics bug in #5010 #5019

RichardHaselgrove opened this issue Nov 18, 2022 · 3 comments · Fixed by #5022

Comments

@RichardHaselgrove
Copy link
Contributor

Describe the bug
Manager command button switches to 'Stop graphics', but has no action.

Applies when graphics window is active: seen on Windows OS only, but expected to apply to Linux too.

Change introduced during work to work round new Mac security demands.

Steps To Reproduce

  1. Click 'Show graphics' button in Manager.
  2. Note button label changes to 'Stop graphics'.
  3. Click it. Graphics window remains open.

Expected behavior
Button acts and closes window, as it does in v7.20.2 and before.

System Information

Additional context
Alternative solution would be to remove the Show / Stop label change, but the consensus is that keeping the display and re-activating - the action would be better.

@CharlieFenton
Copy link
Contributor

Change introduced during work to work round new Mac security demands.

Actually, this bug was introduced in commit 1ab508f on 13 August 2020. Apparently, no one noticed until now.

@RichardHaselgrove
Copy link
Contributor Author

But it isn't expressed in the Windows v7.20.2 release build dated 19 July 2022, which is what misdirected my confirmation tests. There must be some other reason why it has lain dormant until now.

@CharlieFenton
Copy link
Contributor

@RichardHaselgrove You are correct. I didn't read the old code closely enough. The bug is new in 7.20.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants