Mac: More fixes for MacOS 13 and Xcode 14 #5010
Conversation
|
@CharlieFenton, please ignore WebAssembly build errors. They will be automatically fixed later (I pushed a fix to upstream, just waiting for it to be merged) |
|
This PR is ready to be merged. |
|
The code looks fine to me. But since this includes some changes that might affect all platforms (except maybe Android), it would be nice to test it as well before the next major BOINC release. |
|
I've decided to make one more change, so I have made tis PR a draft again. |
|
From my point of view this is not urgent since we don't plan to release next minor release for any platform except OSX. |
|
I have now completed my additional change. Please merge when CI checks have completed. |
|
I'm starting to gather some baseline experience on the current release, to compare with the behaviour after this PR. Machine is Windows 10 Pro I've installed a clean copy of BOINC v7.20.2, user mode, screensaver enabled. Running Einstein: two different apps, both can display their (different) graphics at the same time. One snag: the screensaver never engages automatically - though preview works. I have two large-format DVI-D monitors, each connected via an HDMI output, and digital KVM - adapters where needed. I remember some issues where sensitive HID devices picked up vibrations as user input, so I've tried switching the KVMs to different machines (taking the mouse with them), but no joy. My next step would be rebooting the machine, but one of the Einstein apps hasn't checkpointed in over three hours - that would be a waste. Any other suggestions I can try tomorrow? |
|
OK, starting to look into this. There are no artifacts visible for this PR, so I've loaded the ones from #5017 - that's newer, and there's no overlap in dates, so it should include everything from here and #5002. Einstein (the one I'm most familiar with) is having work-supply problems, but I have some WCG (MCM1) tasks running. First question mark: I can start one or more graphics windows from the 'Show graphics' button. The button changes to 'Stop graphics', and is active, but seems to have no effect - the graphics window stays open. This being Windows, I can close it from the x in the graphics window itself., and the button changes back to 'Show graphics'. I'll try a stock v7.20.2 version, to see if it's WCG's graphics app, but I don't think I've got another machine ready to use for this sub-project, and I'm having difficulty logging in to change my device profiles. I'll leave this one to fire up the screensaver while I look. |
|
OK, the test screensaver opens and clears properly on the test machine. On a Windows 11 machine, with a stock v7.20.2 Manager and a test client dated 13 September 2022, the 'Stop graphics' button works properly with both WCG MCM1 tasks and OPN1 tasks. I think we have a small problem with the new Manager under Windows. |
|
Tested again on Win 7, Einstein BRP app. Same result: screensaver OK, 'Show graphics' OK, close graphics window OK. But 'Stop graphics' from BOINC Manager command button NOT working (graphics window remains open). @CharlieFenton, @AenBleidd - please investigate. |
I had intended for the "Show graphics" button to change to "Stop graphics" only on MacOS, because that is the only platform (as far as I know) where the close button doesn't work on some project graphics apps.
Which is your preference? |
|
@CharlieFenton, I believe, we should have on Windows and linux the behavior we had before your change (the one that is currently on released version). |
|
Done. I agree that Option 2 is better. |
This PR fixes a remaining bug after implementing my previous PR #5002.
Mac: After running screensaver fix slot permissions modified by project gfx apps.
Also updated copyright dates on files I modified in PR #5002.