Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web job submission: retrieving output files #5262

Closed
davidpanderson opened this issue Jun 6, 2023 · 0 comments · Fixed by #5284
Closed

web job submission: retrieving output files #5262

davidpanderson opened this issue Jun 6, 2023 · 0 comments · Fixed by #5284

Comments

@davidpanderson
Copy link
Contributor

davidpanderson commented Jun 6, 2023

The web-based job submission interface (get_output.php) downloads files
with unhelpful names; they don't tell you what job a file is from,
or its logical name, and they don't have the right extension.

I propose a new interface that fixes this by using download file names as follows:

Result:

  • if 1 output file: download name is resultname__logicalname
  • if >1 file: zip the files using their logical names; download it as resultname.zip

Workunit:

  • as above for the canonical instance.

Batch:

  • as above for all WUs in batch; return as batch_batchid.zip

Single file from a result:

  • download name is resultname__logicalname
davidpanderson added a commit that referenced this issue Jun 7, 2023
… files

Problem: the old interface for getting output files (get_output.php)
downloaded files with their physical name,
which is a cryptic string with no extension.
If the output file is, for example, a .zip, you don't see this.
You also don't see the logical name of the file.

Solution: give downloaded files better names.
For example, if a result has a single output file
with logical name 'output.zip',
download it as resultname__output.zip
Similar for multiple output files per result,
for workunits, for single files from a result, and for batches.

Fixes #5262

This can be used as a web API, or directly from web pages (submit.php)
This replaces the old interface,
but I'm leaving it there in case anyone is using it.

Add utility functions for
- getting the full path of an output file
- getting the logical names of a result's output files
@AenBleidd AenBleidd added this to the Server milestone Jun 15, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants