Mac: Fix wxWidgets 3.1.0 Mac-only bug when wxStaticBox has no label #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(this bug has been fixed in wxWidgets 3.1.1)
|
Looks good. Merging. Thanks Charlie! |
TheAspens
added a commit
that referenced
this pull request
Mar 27, 2018
Mac: Fix wxWidgets 3.1.0 Mac-only bug when wxStaticBox has no label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches wxWidgets 3.1.0 on the Mac to fix the bug reported by @DPhilippe4 in PR #1554. This bug was introduced in the Mac (wxCocoa) port of wxWidgets 3.1.0, and has been fixed in wxWidgets 3.1.1. But I feel it is too late in the BOINC 7.10 release cycle to upgrade wxWidgets to 3.1.1 as it won't get adequate testing. (For example, this fairly obvious problem with wxWidgets 3.1.0 was not noticed until the third alpha release 7.9.3; it was not reported in 7.9.1 or 7.9.2 though present in both.)
While analyzing this bug, I have been experimenting with wxWidgets 3.1.1 and found that several changes are needed to BOINC source code to upgrade from 3.1.0 to 3.1.1. I will put those in a separate feature branch for inclusion in the 7.11 / 7.12 release cycle.