Image File Compression #2786
Image File Compression #2786
Conversation
Ran a series of lossless compression algorithms to make the images smaller. Total reduction of ~13MB.
|
Is there any reason to even keep clientgui/res/templates/icons and clientgui/res/templates/skins in the repository? I don't think they are used anywhere. |
|
Are you certain that files such as PNG, TIFF BMP, etc. are still properly displayed on all relevant platforms after this compression? |
|
If anything can be removed entirely, I'm all for it. As for the other files displaying properly, I don't see why they wouldn't. They're the same pictures, just smaller. Unless something is calling the images by their SHA hashes, we should be good. :) There were some files that didn't display at all in Photo Viewer, or Github Desktop untiI had done the optimizations... in client/os2... the .ico files. |
|
My question was directed primarily to @romw and @davidpanderson, because they seem to be artwork which was used to create the images tat are actually used, but they also may be obsolete or at least no longe needed:
|
|
Ah! Pardon me, friend. Just anxious to contribute to something big and useful. Watching the pot boil. lol :D On that same note, I'm going to try my hand optimizing the Pixmap (.xpm) files as well. The program I used to optimize it also stripped the BOINC header information... but it seems there are some more efficient maths that could be pursued within. |
|
@Peppernrino - which tool did you use for the compression and what settings? |
|
Example here: https://pastebin.com/MTtcVck2 :D Applicable tools vary for each file type, but that's what was run on a .png. |
|
Ready to go. The other gentleman scrapped his work. :) |
|
I had the most concern about JPGs, but they don't seem to show any extra conversion artifacts. I also checked a somewhat random sample of files on Windows 10 and all seem to be displayed correctly using standard Windows image viewer. As for removing unused assets, that should not block the merge of this commit. An issue should be raised and somebody can review the files later. |
|
I looked at a random selection of images and they seem fine to me. Any objection to merging? |
|
I have no objection |
Ran a series of lossless compression algorithms to make the images smaller. Total reduction of ~13MB.