-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP debug test only: AMD OpenCL peak flops patch #3006
Conversation
…alo/boinc into JuhaSointusalo-client-gpu-detection
This takes the active ingredient from David's #3001 'fix possible overflow' and applies it in lib/coproc.cpp at COPROC_ATI::set_peak_flops() Posting so that tests can be made on the AppVeyor build: I don't have the necessary hardware.
SU user has confirmed that this build now reports
|
Easier to organize thoughts when writing so putting this here and now instead of in meeting. I would suggest that
|
My reply to that was a bit short. I had not noticed the patch was in library code. Getting useful messages out of library code is not something that is explained in one sentence, or a five minute job, or one line code change. Right now I couldn't tell how to do it and it's quite possible the changes necessary to do it would be too large to fit in to a hotfix. |
The easiest way might be to pass back a 'value limited' flag to the calling routine, and let the client code respond with message code when the flag is present. |
#3001 implemented a workaround for the driver bug in a different way. Closing this as unnecessary. |
Fixes #2988 and #3001 (test only)
Description of the Change
A recent fault in AMD OpenCL driver releases results in a meaningless overflow value being generated for the device GFLOPS peak. This in turn causes tasks to fail (for new machines or new applications) with Error 197: EXIT_TIME_LIMIT_EXCEEDED
Alternate Designs
Research and apply alternative ATI driver metrics to replace the OpenCL 'Max clock frequency'
Release Notes
For testing only. GFLOPS Peak should be capped at 1.e12