wu_check: Skip WUs without input files #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not follow the coding style as described in the wiki, namely - it should either be a one-liner or have curly braces (my preference is the latter). The patch content itself seems valid. |
|
Need braces. Other than that, fine. |
stream1972
force-pushed
the
stream_for_merge
branch
from
a444539
to
05f852b
Compare
|
Braces style fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This tool cannot handle workunits without input files (e.g. if task parameters are set from command line). Accesses uninitialized memory, trying to open a file with a garbage name, prints a garbage on screen. In 'repair' mode, it will erroneously kill these completely normal workunits.
The patch silently skips such types of workunits.
Release Notes
N/A