Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal: Set consistent defaults in flag_abuse module #3372

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

drshawnkwang
Copy link
Contributor

Part of https://dev.gridrepublic.org/browse/DBOINCP-298

Description of the Change
Removed flag default file as it seems to create problems with boinc_standard Features.

Release Notes
N/A

@Germano0
Copy link
Contributor

Part of https://dev.gridrepublic.org/browse/DBOINCP-298

The URL is not accessible without an account

@AenBleidd
Copy link
Member

@Germano0, it's an internal ticket tracking system.
Generally you don't need an access to it

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #3372 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3372      +/-   ##
=========================================
- Coverage    9.27%   9.27%   -0.01%     
=========================================
  Files          36      36              
  Lines        5992    5993       +1     
=========================================
  Hits          556     556              
- Misses       5436    5437       +1
Impacted Files Coverage Δ
lib/coproc.h 0% <0%> (ø) ⬆️
lib/coproc.cpp 0% <0%> (ø) ⬆️
lib/opencl_boinc.h 0% <0%> (ø) ⬆️

@tristanolive
Copy link
Contributor

@Germano0 the ticket system used to be public, but there were some security concerns with JIRA in the past and it was restricted. Since the BOINC-Drupal project is not under active development from many people in the BOINC community, there would be reluctance to opening that ticket system back up to the world; but if you want an account to see the discussion / context, I can set that up for you, no problem.

@tristanolive tristanolive changed the title Drupal: Removed flag default file Drupal: Set consistent defaults in flag_abuse module Nov 19, 2019
@tristanolive
Copy link
Contributor

As for the PR, thanks for the revised approach, Shawn. I think this should help to ensure everything works as expected when a Drupal site is initialized.

@tristanolive tristanolive merged commit 06ed2cf into BOINC:master Nov 19, 2019
@drshawnkwang drshawnkwang deleted the drupal_fix-featureflag branch December 19, 2019 14:53
@AenBleidd AenBleidd added this to the Server Release 1.4.1 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants