remote job submission: add an API function for setting RPC timeout #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a clean copy of #3315 with no unrelated commit |
|
@lfield - are you able to review this PR? I believe that you use the remote submission API and would be in a good position to review. Let me know - thanks! |
|
A question and a comment before I test tomorrow. Is this also needed for the C++ code? I think the Python global should also be rpc_timeout. |
|
I changed the variable name. If anyone asks for this feature in the C++ API I'll add it. |
|
I tested both the Python and PHP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boinc_set_timeout($x): set timeout for job submission RPCs to x seconds