Scheduler (client and server): message tweaks #3402
Conversation
client - show requested delay always (why hide it?) server - ignore residual delay from previous RPC
| ok_to_send_work = false; | ||
| log_messages.printf(MSG_NORMAL, | ||
| "Not sending work - last request too recent, please wait: %f\n", t_left | ||
| "Not sending work - last request too recent, please wait: %f\n", config.min_sendwork_interval |
There was a problem hiding this comment.
This means that user will always see the, let's say, 'default' delay interval even if there is less time left before he can do next request.
E.g.
There is a default delay of 60 sec.
User waits 59 seconds, make another request and see the message that he should wait for 60 seconds more while in fact he had to wait only 1 second before doing next request. Isn't this misleading a little bit?
There was a problem hiding this comment.
he had to wait only 1 second
That's the problem - he didn't. The 1-second message came in an RPC, and the sending of that RPC re-started the timer. He does have to wait the full 60 seconds.
|
I'm ok with the change and plan to merge in in 4 days (on Friday) if there will be no objections before |
to match other scheduler operations (not sched_op_debug, as before) Another tweak to #3402
client - show requested delay always (why hide it?)
server - ignore residual delay from previous RPC
Fixes #3375