Web: fix ReCaptcha problem #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea why, but out of nowhere ReCaptcha stopped working on both SU and S@h. Changing an arg to the recaptcha constructor (from a Stack Overflow entry from 2015) fixed the problem.
Codecov Report
@@ Coverage Diff @@
## master #3461 +/- ##
======================================
Coverage 9.27% 9.27%
======================================
Files 36 36
Lines 5994 5994
======================================
Hits 556 556
Misses 5438 5438 |
AenBleidd
commented
Feb 13, 2020
| @@ -45,7 +45,7 @@ function boinc_recaptcha_get_html($publickey) { | |||
| function boinc_recaptcha_isValidated($privatekey) { | |||
| if ($privatekey) { | |||
| // tells ReCaptcha to use fsockopen() instead of get_file_contents() | |||
| $recaptcha = new \ReCaptcha\ReCaptcha($privatekey, new \ReCaptcha\RequestMethod\SocketPost()); | |||
| $recaptcha = new \ReCaptcha\ReCaptcha($privatekey, new \ReCaptcha\RequestMethod\CurlPost()); | |||
There was a problem hiding this comment.
It is mentioned here that this requires the cURL extension to be enabled in PHP.
I'm not sure but I believe this extension should be either checked or at least mentioned in documentation if its not enabled by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why, but out of nowhere ReCaptcha stopped working on both SU and S@h.
Changing an arg to the recaptcha constructor
(from a Stack Overflow entry from 2015) fixed the problem.