Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install project_specific_defines.h if configured (required by config.h) #3493

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Install project_specific_defines.h if configured (required by config.h) #3493

merged 1 commit into from
Mar 17, 2020

Conversation

brevilo
Copy link
Contributor

@brevilo brevilo commented Mar 6, 2020

Fixes #3471

Description of the Change
Installs project_specific_defines.h in PREFIX/include/boinc if --enable-install-headers is configured. It's included by config.h which in turn gets used when building science apps or screensavers. Right now config.h isn't installed, but that's a separate issue dealt with in #2964.

Release Notes
n/a

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #3493 into master will not change coverage by %.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3493   +/-   ##
======================================
  Coverage    9.27%   9.27%           
======================================
  Files          36      36           
  Lines        5994    5994           
======================================
  Hits          556     556           
  Misses       5438    5438           

@brevilo
Copy link
Contributor Author

brevilo commented Mar 17, 2020

Hey @AenBleidd or @lfield, could you have a look at this one? Thanks

@AenBleidd
Copy link
Member

Ideally, svn_version.h file should be refactored and renamed because now we're using git and it is a little bit confusing. But this is not in the scope of this ticket, so I'm ok.

@brevilo
Copy link
Contributor Author

brevilo commented Mar 17, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config.h depends on project_specific_defines.h which is never installed
2 participants