db_purge: fix truncated mod_time data (field too small for timestamp) #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3539 +/- ##
=======================================
Coverage 15.49% 15.49%
=======================================
Files 105 105
Lines 8650 8650
Branches 1613 1613
=======================================
Hits 1340 1340
Misses 7171 7171
Partials 139 139 |
|
@stream1972 - the change looks good to me - but I think that the same change should be made to RESULT.mod_time for the same reason. Can you add that to your pull request as well? Thanks! |
|
@TheAspens Patch already includes changes for both structures. |
|
Sigh - my apologies for missing that. Looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Full timestamp is 19 characters long, so it need a 20-bytes buffer.
This is minor issue - this field is used only by db_purge. It causes db_purge output of this field to be truncated.
Alternate Designs
Release Notes
N/A