-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drupal: Add CKEditor module and library #3573
Drupal: Add CKEditor module and library #3573
Conversation
Adds ckeditor module and JS library to drupal. Part of https://dev.gridrepublic.org/browse/DBOINCP-523
For SA-CONTRIB-2020-007 See https://www.drupal.org/project/d6lts/issues/3120661 Part of https://dev.gridrepublic.org/browse/DBOINCP-523
Added user permissions and CKEditor profiles.
@drshawnkwang, is it possible to use git submodules instead of copy-paste updated 3rdparty code? |
Codecov Report
@@ Coverage Diff @@
## master #3573 +/- ##
==========================================
- Coverage 18.79% 18.09% -0.70%
==========================================
Files 99 107 +8
Lines 8406 8803 +397
Branches 1601 1542 -59
==========================================
+ Hits 1580 1593 +13
- Misses 6717 7094 +377
- Partials 109 116 +7
|
When the Drupal project was started more than five-years ago we started using this workflow: putting the 3rd-party JS libraries into the drupal portion of the repo. It's not the best solution, but at the time these libraries were not always available in a git repo somewhere: often there are {{.zip}} files you extract into your Drupal site. It would be a rather large effort to go back and try to re-implement all this with submodules. |
Added user_roles to Feature, needed for CKEditor. Fixed array declaration that was overriding the Feature. Removed old wysiwyg code.
This reverts commit ad0cf5e.
CKEditor profile changes too because of this.
submodules: I agree with Shawn here. Technically it's of course possible but right now I don't think it would be worth the effort. |
Part of https://dev.gridrepublic.org/browse/DBOINCP-523
Description of the Change
Replace tinyMCE with CKEditor module and library.
Release Notes
N/A