Drupal: Add CKEditor module and library #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 6, 2020 14:19
Adds ckeditor module and JS library to drupal. Part of https://dev.gridrepublic.org/browse/DBOINCP-523
For SA-CONTRIB-2020-007 See https://www.drupal.org/project/d6lts/issues/3120661 Part of https://dev.gridrepublic.org/browse/DBOINCP-523
Added user permissions and CKEditor profiles.
|
@drshawnkwang, is it possible to use git submodules instead of copy-paste updated 3rdparty code? |
Codecov Report
@@ Coverage Diff @@
## master #3573 +/- ##
==========================================
- Coverage 18.79% 18.09% -0.70%
==========================================
Files 99 107 +8
Lines 8406 8803 +397
Branches 1601 1542 -59
==========================================
+ Hits 1580 1593 +13
- Misses 6717 7094 +377
- Partials 109 116 +7
|
When the Drupal project was started more than five-years ago we started using this workflow: putting the 3rd-party JS libraries into the drupal portion of the repo. It's not the best solution, but at the time these libraries were not always available in a git repo somewhere: often there are {{.zip}} files you extract into your Drupal site. It would be a rather large effort to go back and try to re-implement all this with submodules. |
drshawnkwang
changed the title
drshawnkwang
changed the title
drshawnkwang
changed the title
added 6 commits
April 16, 2020 10:49
Added user_roles to Feature, needed for CKEditor. Fixed array declaration that was overriding the Feature. Removed old wysiwyg code.
This reverts commit ad0cf5e.
CKEditor profile changes too because of this.
|
submodules: I agree with Shawn here. Technically it's of course possible but right now I don't think it would be worth the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://dev.gridrepublic.org/browse/DBOINCP-523
Description of the Change
Replace tinyMCE with CKEditor module and library.
Release Notes
N/A