Server programs: try to print error message if can't connect to DB #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3672 +/- ##
=========================================
Coverage 18.90% 18.90%
Complexity 751 751
=========================================
Files 105 105
Lines 8654 8654
Branches 1524 1524
=========================================
Hits 1636 1636
Misses 6903 6903
Partials 115 115 |
AenBleidd
requested changes
May 6, 2020
| @@ -85,10 +85,14 @@ int DB_CONN::open( | |||
| // CLIENT_FOUND_ROWS means that the # of affected rows for an update | |||
| // is the # matched by the where, rather than the # actually changed | |||
| // | |||
| mysql = mysql_real_connect( | |||
| MYSQL* mysql2 = mysql_real_connect( | |||
There was a problem hiding this comment.
What is the reason of adding new variable here? In case of unsuccessful connect, mysql variable will still be uninitialized.
There was a problem hiding this comment.
If the connect failed, mysql will be NULL. mysql_errno() and mysql_error() require a non-NULL argument.
There was a problem hiding this comment.
But will mysql contain relevant error information then?
There was a problem hiding this comment.
Yes. It will contain info about the fail connect.
AenBleidd
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.