Drupal: fixed regression in df966c74 #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The original commit fixed the goto/pagination for admins/mods but broke it for regular users * We need to handle *both* user groups differently (i.e. conditionally include hidden comments)
|
Assigning you Tristan since Shawn moved on. Please wait with the merge itself until I removed the WIP tag. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #3894 +/- ##
=======================================
Coverage 16.51% 16.51%
=======================================
Files 134 134
Lines 13148 13148
Branches 1627 1627
=======================================
Hits 2172 2172
Misses 10844 10844
Partials 132 132 |
brevilo
changed the title
|
[WIP] tag removed. You may merge when ready 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Release Notes
N/A