Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote job submission: specify all fields on batch creation. #4030

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

davidpanderson
Copy link
Contributor

Newer versions of MySQL error out if you don't.

Fixes #4029

Newer versions of MySQL error out if you don't.
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #4030 into master will increase coverage by 7.91%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4030      +/-   ##
============================================
+ Coverage      8.74%   16.66%   +7.91%     
- Complexity        0      752     +752     
============================================
  Files            36      134      +98     
  Lines          6062    13131    +7069     
  Branches          0     1492    +1492     
============================================
+ Hits            530     2188    +1658     
- Misses         5532    10827    +5295     
- Partials          0      116     +116     
Impacted Files Coverage Δ Complexity Δ
...p/src/main/java/edu/berkeley/boinc/rpc/WorkUnit.kt 37.93% <0.00%> (ø) 11.00% <0.00%> (?%)
...app/src/main/java/edu/berkeley/boinc/rpc/Notice.kt 34.28% <0.00%> (ø) 12.00% <0.00%> (?%)
...ey/boinc/client/ClientInterfaceImplementation.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
.../edu/berkeley/boinc/rpc/GlobalPreferencesParser.kt 92.24% <0.00%> (ø) 51.00% <0.00%> (?%)
...edu/berkeley/boinc/attach/SelectionListActivity.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...in/java/edu/berkeley/boinc/rpc/AccountOutParser.kt 80.00% <0.00%> (ø) 8.00% <0.00%> (?%)
...n/java/edu/berkeley/boinc/client/DeviceStatus.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...java/edu/berkeley/boinc/receiver/BOINCReceivers.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...rc/main/java/edu/berkeley/boinc/rpc/VersionInfo.kt 50.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...eley/boinc/adapter/ClientLogRecyclerViewAdapter.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 88 more

@Rytiss Rytiss merged commit 03b2e00 into master Oct 3, 2020
@Rytiss Rytiss deleted the dpa_submit_batch branch October 3, 2020 07:29
@AenBleidd AenBleidd added this to the Server milestone Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remote job submission bug
3 participants