GPU list: strip leading "AMD" or "NVIDIA" from model to avoid dups in list #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AenBleidd
reviewed
May 1, 2021
html/user/gpu_list.php
Outdated
| // strip leading AMD or NVIDIA | ||
| // | ||
| function strip_vendor($model) { | ||
| foreach (array("AMD ", "NVIDIA ") as $maker) { |
There was a problem hiding this comment.
I'd suggest to add "ATI " and "Intel(R) " to this list
Codecov Report
@@ Coverage Diff @@
## master #4354 +/- ##
===========================================
- Coverage 7.66% 7.66% -0.01%
Complexity 792 792
===========================================
Files 277 277
Lines 35557 35566 +9
Branches 1554 1556 +2
===========================================
Hits 2727 2727
- Misses 32698 32707 +9
Partials 132 132
|
AenBleidd
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4353