Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_versions: add --noconfirm option #4996

Merged
merged 2 commits into from
Nov 9, 2022
Merged

update_versions: add --noconfirm option #4996

merged 2 commits into from
Nov 9, 2022

Conversation

davidpanderson
Copy link
Contributor

No description provided.

@AenBleidd AenBleidd closed this Nov 5, 2022
@AenBleidd AenBleidd reopened this Nov 5, 2022
@AenBleidd
Copy link
Member

@davidpanderson, for some reason server integration tests is failing trying to connect to the server running in docker container.
I assume this happens because server instance was not created properly.
Could you please check this somehow and fix?

@davidpanderson
Copy link
Contributor Author

davidpanderson commented Nov 5, 2022 via email

@AenBleidd
Copy link
Member

Not sure this is really related: I tried to rerun and it always fails on this PR and never fails on any other without this change.
I can dig to find the exact reason

@davidpanderson
Copy link
Contributor Author

That's odd - the automated build AFAIK doesn't involve this file.

@AenBleidd
Copy link
Member

@davidpanderson
Copy link
Contributor Author

Oops!! I accidentally made it non-executable. Fixed now.

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #4996 (bc660d9) into master (1adb567) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4996      +/-   ##
============================================
- Coverage     10.83%   10.83%   -0.01%     
  Complexity     1064     1064              
============================================
  Files           279      279              
  Lines         35994    35995       +1     
  Branches       8127     8127              
============================================
  Hits           3899     3899              
- Misses        31706    31707       +1     
  Partials        389      389              
Impacted Files Coverage Δ
.../src/main/java/edu/berkeley/boinc/TasksFragment.kt 0.00% <0.00%> (ø)

@AenBleidd
Copy link
Member

@lfield, would be nice if you could review this as well.

@lfield
Copy link
Contributor

lfield commented Nov 9, 2022

LGTM

@lfield lfield merged commit d8ddefb into master Nov 9, 2022
@AenBleidd AenBleidd deleted the dpa_uv branch August 15, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants