-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Build example applications, wrapper and vboxwrapper for OSX. #5056
Conversation
@AenBleidd I haven't looked at the other samples, but example_app/Makefile_mac is obviously out of date. Fro example, it has: |
@AenBleidd Also, in example_app/MakeMacExample.sh you may want to update You may want to make similar changes for the other two samples. But since these are only warnings, all 3 builds should succeed without these changes. |
@CharlieFenton, thanks for the hint. I'll slowly step by step fix build issues and update these scripts. When done - I'll definitely ask to review them. Thank you in advance. |
I forgot to mention: if you do this, you should also change |
24672e6
to
4b93088
Compare
b97b089
to
1c01a30
Compare
c90abe8
to
682f094
Compare
@CharlieFenton, PR is ready for your review, please check it. |
Thank you. I will review some time this week. |
@AenBleidd Thank you for the changes. We are almost there! A few more items: In BuildMacBOINC.sh: The usage message (in response to the You have this comment for the
It might be better to automatically set In example_app/ReadMe.txt: Please change line 16 from |
682f094
to
f8be2f9
Compare
Basically, this is not good for ci, because it will build libs 3 more times, but from the user pov - this is definitely better, so I fixed that. Both other comments are fixed as well. @CharlieFenton, please re-review. |
This fixes BOINC#4892. Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
f8be2f9
to
797cbc8
Compare
@AenBleidd I have approved this PR, but I see one of the CI builds is failing, so I have not merged it. |
Yeah, that was a CI issue during downloading of some tool. I rerun it and everything is fine, so I'm gonna merge it now. |
This fixes #4892.
Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com