Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Build example applications, wrapper and vboxwrapper for OSX. #5056

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

AenBleidd
Copy link
Member

@AenBleidd AenBleidd commented Jan 7, 2023

This fixes #4892.

Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com

@CharlieFenton
Copy link
Contributor

@AenBleidd I haven't looked at the other samples, but example_app/Makefile_mac is obviously out of date. Fro example, it has: FREETYPE_DIR = $(BOINC_DIR)/../freetype-2.4.10 when the current dependent version specified in mac_build/dependencyNames.sh is freetype-2.11.0. I suspect this may be the reason for the build failure.

@CharlieFenton
Copy link
Contributor

@AenBleidd Also, in example_app/MakeMacExample.sh you may want to update -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to -DMAC_OS_X_VERSION_MAX_ALLOWED=101300, and change export MACOSX_DEPLOYMENT_TARGET=10.7 to export MACOSX_DEPLOYMENT_TARGET=10.13 to eliminate the warnings "was built for newer macOS version (10.13) than being linked (10.7)".

You may want to make similar changes for the other two samples. But since these are only warnings, all 3 builds should succeed without these changes.

@AenBleidd
Copy link
Member Author

@CharlieFenton, thanks for the hint. I'll slowly step by step fix build issues and update these scripts. When done - I'll definitely ask to review them. Thank you in advance.

@CharlieFenton
Copy link
Contributor

Also, in example_app/MakeMacExample.sh you may want to update -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to -DMAC_OS_X_VERSION_MAX_ALLOWED=101300, and change export MACOSX_DEPLOYMENT_TARGET=10.7 to export MACOSX_DEPLOYMENT_TARGET=10.13 to eliminate the warnings "was built for newer macOS version (10.13) than being linked (10.7)".

I forgot to mention: if you do this, you should also change -DMAC_OS_X_VERSION_MIN_REQUIRED=1070 to -DMAC_OS_X_VERSION_MIN_REQUIRED=101300. And similar changes for the other two samples.

@AenBleidd AenBleidd force-pushed the vko_add_more_osx_ci branch 24 times, most recently from 24672e6 to 4b93088 Compare January 10, 2023 17:37
@AenBleidd AenBleidd force-pushed the vko_add_more_osx_ci branch 2 times, most recently from b97b089 to 1c01a30 Compare January 17, 2023 09:15
@AenBleidd AenBleidd force-pushed the vko_add_more_osx_ci branch 10 times, most recently from c90abe8 to 682f094 Compare February 6, 2023 00:57
@AenBleidd AenBleidd marked this pull request as ready for review February 6, 2023 02:25
@AenBleidd
Copy link
Member Author

@CharlieFenton, PR is ready for your review, please check it.
buildjpeg.sh was removed by intention because it's obsolete and its functionality was moved to XCode project file.

@CharlieFenton
Copy link
Contributor

Thank you. I will review some time this week.

@CharlieFenton
Copy link
Contributor

@AenBleidd Thank you for the changes. We are almost there! A few more items:

In BuildMacBOINC.sh:

The usage message (in response to the -help argument or a bad argument is missing the following options:
[-libstdc++]
[-zipapps]
[-uc2]
[-vboxwrapper]

You have this comment for the [-zipapps], [-uc2] and [-vboxwrapper] arguments:

If run as a single target and not in sequence when libs are already build it will fail to build without -lib parameter specified

It might be better to automatically set $buildlibs=1 if any of these 3 arguments are passed. What do you think?

In example_app/ReadMe.txt:

Please change line 16 from sh MakeMacExample.sh to source MakeMacExample.sh

@AenBleidd
Copy link
Member Author

It might be better to automatically set $buildlibs=1 if any of these 3 arguments are passed. What do you think?

Basically, this is not good for ci, because it will build libs 3 more times, but from the user pov - this is definitely better, so I fixed that.

Both other comments are fixed as well.

@CharlieFenton, please re-review.

This fixes BOINC#4892.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@CharlieFenton
Copy link
Contributor

@AenBleidd I have approved this PR, but I see one of the CI builds is failing, so I have not merged it.

@AenBleidd
Copy link
Member Author

@AenBleidd I have approved this PR, but I see one of the CI builds is failing, so I have not merged it.

Yeah, that was a CI issue during downloading of some tool. I rerun it and everything is fine, so I'm gonna merge it now.
@CharlieFenton, thank you for your review, your time and your assistance.
I really appreciate this.

@AenBleidd AenBleidd merged commit 3faca20 into BOINC:master Feb 14, 2023
@AenBleidd AenBleidd deleted the vko_add_more_osx_ci branch February 14, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Add 'samples/wrapper/BuildMacWrapper.sh' to CI build flow
2 participants