Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux][Manager][vcpkg] Fix Linux vcpkg manager compilation #5098

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Feb 13, 2023

Hello @davidpanderson
Here is a bug fix of compilation of vcpkg manager in ubuntu.
It not compile correctly with the ld flags, results unable to run the compiled manager under ubuntu 22.04, and maybe other Linux distro / versions.
This is known issue and I test my fix on my wsl2 ubuntu 22.04.
Fix microsoft/vcpkg#25786

I decided to continue contribute and not let ruined for me and the boinc community and let it improve and grow.

Here some of my contributions to boinc in the recent year:

  • Android boinc switch to dark mode along with all icons convert them to graphic vector images.
  • Android boinc add tcp ip mode, also lead to remote control on android.
  • Refactor Android Monitor to kotlin making it MonitorAsync.
  • Add support ARMv6 devices to android.
  • Started the wasm direction that can lead boinc web client.
  • Started to flutter direction that can lead to prettier and cross platform ui (Desktop, mobile and web). (clientgui).
  • Fix Linux skins.

I want to continue contribute, here some of the subjects I can contribute

  • Add http2 connection support to servers (world community grid and BOINC Account Manager are support it).
  • Compile boinc in snap package
  • Compile boinc in flatpack package

Optional directions:

  • Add support ipv6 between client and clientgui. (Currently only ipv4 support).
  • TLS on android. (One of the requirement to come back google play)
  • Split to android apps (One of the requirement to come back google play)
  • Continue flutter
  • Continue wasm
  • Other

I also love to see my ideas such a release android and desktop at once, and be in google summer of code, are implements and grow in the community.

I request take account my professional knowledge, do not add additional conditions for contributions and Vitalii doesn't represent my will and my actions.

Copy link
Member

@AenBleidd AenBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks legit.
Still required some testing to be done to verify that the crash has been fixed

@AenBleidd
Copy link
Member

I decided to continue contribute and not let ruined for me and the boinc community and let it improve and grow.

This and everything below don't belong to the fix.
@talregev, if you want to address this message to David, you should write an email to him because GitHub is not a preferred way of such conversations.

I request take account my professional knowledge, do not add additional conditions for contributions

All requirements to contributions are applied to all contributions without taking into account any professional experience of any particular contributor. We treat every contributor equally without any exceptions.
Also, this (like any other) project has its requirements and guidelines, and all contributors are expected to follow them without any exceptions.

@talregev
Copy link
Contributor Author

Some screenshot from my wsl2:
image

@AenBleidd
Copy link
Member

I see no crash when running this on Ubuntu 22.04
image

@AenBleidd
Copy link
Member

Thanks for the contribution, @talregev

@AenBleidd AenBleidd merged commit 1f1585e into BOINC:master Feb 13, 2023
@talregev talregev deleted the TalR/fix_manager_vcpkg_compilation branch February 13, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wxwidget] run time error on ubuntu 22.04
2 participants