-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client and server: increase p_features size from 1024 to 8192. #5123
Conversation
1024 wasn't enough for some CPUs. This caused some hosts to not get sse3 app versions, for example. Note: ideally we'd change this to std::string. But that would have disrupted the code that populates it (hostinfo_unix.cpp, hostinfo_win.cpp). Easier/safer to do it this way.
Android and Webassembly are expected to fail, so could be ignored for now |
In the current version of the code (master branch), p_features size of the host record is still fixed 1024. That doesn't look right (and probably won't help):
https://github.com/BOINC/boinc/blob/master/db/boinc_db_types.h#L369 |
@davidpanderson @AenBleidd this probably isn't fixed yet. |
complete #5123: client and server: increase p_features size from 1024 to 8192
@AenBleidd @davidpanderson does this omission in boinc_db_types affect the server only, or the client as well? |
@bema-aei, from what I see in the code, this is for the server only |
Server only. Thanks for fixing this. |
1024 wasn't enough for some CPUs.
This caused some hosts to not get sse3 app versions, for example.
Note: ideally we'd change this to std::string.
But that would have disrupted the code that populates it (hostinfo_unix.cpp, hostinfo_win.cpp).
Easier/safer to do it this way.
Fixes #5122