Mac Installer & Uninstaller: Fix display of name of helper apps #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… MacOS 13 Ventura - Fix installing a branded build over unbranded or an unbranded build over branded.
AenBleidd
reviewed
Mar 6, 2023
Just a typo, though probably no consequence. I fixed it. I'm working on fixing the CI build failure. |
|
@AenBleidd Since I only changed Mac-specific files, I believe the CI errors for Android and Webassembly are not due to anything in this PR. This PR is ready for merging once the MacOS CI builds succeed. |
|
@CharlieFenton, yes, Android and WebAssembly are expected to fail now. |
AenBleidd
approved these changes
Mar 8, 2023
This was referenced Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac Installer & Uninstaller:
When a Mac is configured with multiple users, the BOINC installer and uninstaller temporarily install a small helper app for each user who is not currently logged in, and creates a LaunchAgent for each of those users. The next time the user logs in, the LaunchAgent runs the helper app, which completes the install or uninstall process for that user and then deletes itself and its associated LaunchAgent.
Instead of the name of the helper app (BOINC_Finish_Install or BOINC_Finish_Uninstall), MacOS 13 Ventura incorrectly displayed the name of the developer who code signed it. Currently, that is my name. Because the developer's name is not familiar to the users, it can cause them concern. This fixes that issue, which was a side effect of my changes from PR #5115.
It also fixes several other small issues I discovered while testing the changes for this PR, primarily when a user has unbranded (standard) BOINCManager installed and then installs a branded version to replace it (for example, World Community Grid.) Also in the reverse case, such as when installing BOINCManager to replace a branded version such as World Community Grid.