Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix: vcpkg will clone from $VCPKG_LINK #5127

Merged

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Mar 6, 2023

Fix: vcpkg will clone from $VCPKG_LINK.

@talregev talregev force-pushed the TalR/fix_upfate_vcpkg_wasm_vcpkg_link branch from 8c19b8f to 2f2a9be Compare March 9, 2023 13:13
@talregev talregev changed the title [wasm][ci] Fix wasm vcpkg: clone from $VCPKG_LINK [ci] Fix: vcpkg will clone from $VCPKG_LINK Mar 9, 2023
@talregev talregev force-pushed the TalR/fix_upfate_vcpkg_wasm_vcpkg_link branch from 2f2a9be to c2250e3 Compare March 14, 2023 21:19
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #5127 (924b85c) into master (8494e83) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5127      +/-   ##
============================================
- Coverage     10.85%   10.85%   -0.01%     
  Complexity     1064     1064              
============================================
  Files           279      279              
  Lines         35989    35992       +3     
  Branches       8257     8258       +1     
============================================
  Hits           3907     3907              
- Misses        31690    31693       +3     
  Partials        392      392              

see 2 files with indirect coverage changes

@talregev talregev force-pushed the TalR/fix_upfate_vcpkg_wasm_vcpkg_link branch 3 times, most recently from 81e54d3 to 71dd117 Compare March 14, 2023 23:36
@talregev talregev force-pushed the TalR/fix_upfate_vcpkg_wasm_vcpkg_link branch from 71dd117 to 924b85c Compare March 14, 2023 23:52
Copy link
Member

@AenBleidd AenBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

@AenBleidd AenBleidd added this to the Client/Manager 7.22.1 milestone Mar 15, 2023
@AenBleidd AenBleidd merged commit 5948920 into BOINC:master Mar 15, 2023
@talregev talregev deleted the TalR/fix_upfate_vcpkg_wasm_vcpkg_link branch March 18, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants