Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: print Y/M/D as well as time in log messages #5161

Merged
merged 1 commit into from
Mar 22, 2023
Merged

API: print Y/M/D as well as time in log messages #5161

merged 1 commit into from
Mar 22, 2023

Conversation

davidpanderson
Copy link
Contributor

Fixes #5155

@AenBleidd AenBleidd self-assigned this Mar 22, 2023
@AenBleidd AenBleidd added this to the Client/Manager 7.22.1 milestone Mar 22, 2023
AenBleidd
AenBleidd approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@AenBleidd AenBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thank you for the fix.

@AenBleidd AenBleidd merged commit bcb786b into master Mar 22, 2023
@BrianNixon
Copy link
Contributor

Does WRAPPER_RELEASE need to be bumped for a change like this?

@AenBleidd
Copy link
Member

Does WRAPPER_RELEASE need to be bumped for a change like this?

Only when making new release. Not sure this worth to make it now since there are no other significant changes, and this is not a critical bug fix.

@davidpanderson, What do you think?
If you want, I can make a new release of BOINC Wrapper.

@BrianNixon
Copy link
Contributor

Only when making new release.

Fair enough.

If you want, I can make a new release of BOINC Wrapper.

I’m not pushing for a release; just wanted to check that an update hadn’t gone overlooked…

(Some SCM policies require every change to a component to change its version number, otherwise you can end up with two copies of a program claiming to be the same version but producing different output.)

@AenBleidd AenBleidd deleted the dpa_api_log branch August 15, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AenBleidd AenBleidd AenBleidd approved these changes

Assignees

@AenBleidd AenBleidd

Labels
C: BOINC - API P: Trivial PR: Reviewed T: Enhancement
Projects
None yet
Milestone
Client/Manager 7.22.1
Development

Successfully merging this pull request may close these issues.

Add date to task log messages
3 participants
@davidpanderson @BrianNixon @AenBleidd