Fix some compile warnings on Win (VS 2022). #5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove outdated stuff (e.g. VS has snprintf() now). I'd like to have a clean build (no warnings) on both VS and gcc. Currently VS has a bunch of printf code warnings in diagnostics.cpp, diagnostics_win.cpp, and stackwalker_win.cpp. These should be easy to fix. gcc has a bunch of sprintf buffer-size warnings, not easy to fix. There are lots of warnings in zip (to be fixed with vcpkg?) and in old graphics code.
Yep. I want to remove this old 3rdparty libraries from our repo and install them as a dependencies. @davidpanderson, could you please fix build errors meanwhile? |
|
Currently manager build on linux vcpkg ix expected to fail. I'm working on a fix. |
|
Also lots of |
Use snprintf() instead of sprintf() in a few places (should eventually do it everywhere) Notes: (void)x; seems to work (cross-platform) for suppressing unused arg warnings. int n; n = snprintf(buf, sizeof(buf), ....) (void)n; works in some cases for suppressing buffer-size warnings. But not all cases. Not sure why.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5163 +/- ##
=========================================
Coverage 10.85% 10.85%
Complexity 1064 1064
=========================================
Files 279 279
Lines 35992 35992
Branches 8258 8258
=========================================
Hits 3907 3907
Misses 31693 31693
Partials 392 392
|
|
I think I'm done with this PR. |
|
I'll review it. |
AenBleidd
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove outdated stuff (e.g. VS has snprintf() now).
I'd like to have a clean build (no warnings) on both VS and gcc. Currently VS has a bunch of printf code warnings in diagnostics.cpp, diagnostics_win.cpp, and stackwalker_win.cpp. These should be easy to fix.
gcc has a bunch of sprintf buffer-size warnings, not easy to fix. There are lots of warnings in zip (to be fixed with vcpkg?) and in old graphics code.