-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: improve file checking on task start #5167
Conversation
When a task starts: - don't re-checksum its files. This was already done after the file was downloaded. Doing it again doesn't accomplish anything, and causes performance problems if the file is big. - do check that the files exist and have the right size - if the program launch (e.g. exec()) fails, re-checksum the app version files on the (unlikely) chance that one of them was accidentally corrupted.
Fix problem in boinc_stdio.h
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5167 +/- ##
============================================
+ Coverage 10.85% 10.86% +0.01%
Complexity 1064 1064
============================================
Files 279 279
Lines 35992 35993 +1
Branches 8258 8258
============================================
+ Hits 3907 3911 +4
+ Misses 31693 31690 -3
Partials 392 392
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLIENT_STATE::task_files_present()
: Suggest mentioning the side-effect of check_size
, otherwise it’s not obvious why the early returns get removed
Co-authored-by: Brian Nixon <nixonb@yahoo.com>
When a task starts:
This was already done after the file was downloaded.
Doing it again doesn't accomplish anything,
and causes performance problems if the file is big.
re-checksum the app version files on the (unlikely) chance
that one of them was accidentally corrupted.
Fixes #5165