client: improve file checking on task start #5167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a task starts:
- don't re-checksum its files.
This was already done after the file was downloaded.
Doing it again doesn't accomplish anything,
and causes performance problems if the file is big.
- do check that the files exist and have the right size
- if the program launch (e.g. exec()) fails,
re-checksum the app version files on the (unlikely) chance
that one of them was accidentally corrupted.
Fix problem in boinc_stdio.h
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5167 +/- ##
============================================
+ Coverage 10.85% 10.86% +0.01%
Complexity 1064 1064
============================================
Files 279 279
Lines 35992 35993 +1
Branches 8258 8258
============================================
+ Hits 3907 3911 +4
+ Misses 31693 31690 -3
Partials 392 392
|
AenBleidd
requested changes
Mar 26, 2023
BrianNixon
reviewed
Mar 26, 2023
BrianNixon
reviewed
Mar 26, 2023
Co-authored-by: Brian Nixon <nixonb@yahoo.com>
AenBleidd
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task starts:
This was already done after the file was downloaded.
Doing it again doesn't accomplish anything,
and causes performance problems if the file is big.
re-checksum the app version files on the (unlikely) chance
that one of them was accidentally corrupted.
Fixes #5165