Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manager][Windows] Prevent close request on minimized window exiting the app #5174

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[Manager][Windows] Prevent close request on minimized window exiting the app #5174

merged 1 commit into from
Mar 31, 2023

Conversation

BrianNixon
Copy link
Contributor

Fixes #5164

@AenBleidd
Copy link
Member

@RichardHaselgrove, could you please test this?

@RichardHaselgrove
Copy link
Contributor

Will do, a little later this morning.

@RichardHaselgrove
Copy link
Contributor

I'm sorry - I'm getting nowhere with this. Github is playing up - keeps failing to follow links: CI hasn't created any artifacts - I could build my own, but it would take longer: and I can't reproduce the original problem.

Tested under Windows 7 and Windows 11. Clicking the mouse wheel has no effect (I don't have a three-button mouse), and right-clicking on a minimised icon doesn't have the reported effect. 'Close window' (or 'Close all windows', if the event log is also visible), does close the windows: but I have my machines set up to display the notification area icon at all times, and that shows that the Manager is still running in 'hidden' mode - it can be re-launched from the icon.

I think we may need to request further information from the author of #5164, as to exactly what curtomisations he has applied to his system.

@AenBleidd
Copy link
Member

Ok, I'll try to test this on my side

@AenBleidd AenBleidd closed this Mar 31, 2023
@AenBleidd AenBleidd reopened this Mar 31, 2023
@AenBleidd
Copy link
Member

Tested on Windows. Works as expected.

@AenBleidd AenBleidd merged commit 80050f1 into BOINC:master Mar 31, 2023
@BrianNixon BrianNixon deleted the manager_minimized_close branch March 31, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BOINC Manager exits completely when closing minimised window.
3 participants