[Lib] Improve Windows diagnostics #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5191 +/- ##
=========================================
Coverage 10.86% 10.86%
Complexity 1064 1064
=========================================
Files 279 279
Lines 35993 35990 -3
Branches 8258 8256 -2
=========================================
Hits 3911 3911
+ Misses 31690 31687 -3
Partials 392 392
|
AenBleidd
requested changes
Apr 11, 2023
|
General comments:
|
AenBleidd
approved these changes
Apr 16, 2023
|
@BrianNixon, in general I'm ok with this PR. But next time please try to make PRs as atomic as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all the bugs the compiler has been warning about, and several others I found while I was in there