Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux][vcpkg] Detect vcpkg freeglut for linux #5198

Merged
merged 1 commit into from
Apr 16, 2023
Merged

[Linux][vcpkg] Detect vcpkg freeglut for linux #5198

merged 1 commit into from
Apr 16, 2023

Conversation

talregev
Copy link
Contributor

Detect vcpkg freeglut for linux

@talregev talregev force-pushed the TalR/linux_detect_vcpkg_freeglut branch 2 times, most recently from 5844685 to f06d1e6 Compare April 16, 2023 06:32
AenBleidd
AenBleidd requested changes Apr 16, 2023
View reviewed changes
Copy link
Member

@AenBleidd AenBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If screensaver was not built before but now is building with the changes in this PR, please update https://github.com/BOINC/boinc/blob/master/deploy/prepare_deployment.py file to include new artifact.
Also, it would be nice (but not mandatory) if you check that screensaver could be built without vcpkg and if not, update our CI to include needed dependencies.

Thank you in advance.

configure.ac Outdated Show resolved Hide resolved
@talregev
Copy link
Contributor Author

talregev commented Apr 16, 2023 •
edited
Loading

The screen server was built before. Nothing change about that. Only msg in config process was added.
This PR is mainly to detect properly vcpkg freeglut when we build the apps.

@talregev talregev force-pushed the TalR/linux_detect_vcpkg_freeglut branch from f06d1e6 to 04db964 Compare April 16, 2023 21:13
@talregev talregev requested a review from AenBleidd April 16, 2023 21:17
AenBleidd
AenBleidd requested changes Apr 16, 2023
View reviewed changes
Copy link
Member

@AenBleidd AenBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add 'clientscr' file to the https://github.com/BOINC/boinc/blob/master/deploy/prepare_deployment.py file? Because it's obviously missed and should be there.

Thank you in advance.

@talregev
Copy link
Contributor Author

Could you please add 'clientscr' file to the https://github.com/BOINC/boinc/blob/master/deploy/prepare_deployment.py file? Because it's obviously missed and should be there.

Thank you in advance.

No. It for another PR. This PR is for Detect vcpkg freeglut.

@AenBleidd AenBleidd added this to the Client/Manager 7.22.1 milestone Apr 16, 2023
@AenBleidd AenBleidd merged commit 3696184 into BOINC:master Apr 16, 2023
@talregev talregev deleted the TalR/linux_detect_vcpkg_freeglut branch April 16, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AenBleidd AenBleidd AenBleidd approved these changes

Assignees
No one assigned
Labels
C: Build System P: Trivial PR: Reviewed T: Bugfix
Projects
None yet
Milestone
Client/Manager 7.22.1
Development

Successfully merging this pull request may close these issues.
2 participants
@talregev @AenBleidd