Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Simplify vcpkg custom triplets #5208

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[CI] Simplify vcpkg custom triplets #5208

merged 1 commit into from
Apr 27, 2023

Conversation

AenBleidd
Copy link
Member

No description provided.

@AenBleidd
[CI] Simplify vcpkg custom triplets
2d2a89d 
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd
Copy link
Member Author

@talregev, would be nice if you could review this PR.
Thank you in advance.

@AenBleidd AenBleidd requested a review from talregev April 27, 2023 18:00
@AenBleidd AenBleidd marked this pull request as ready for review April 27, 2023 18:00
@AenBleidd
Copy link
Member Author

Linux integration test is expected to fail, so please ignore it

@AenBleidd AenBleidd self-assigned this Apr 27, 2023
@AenBleidd AenBleidd added this to the Client/Manager 7.22.1 milestone Apr 27, 2023
@talregev
Copy link
Contributor

It would be nice if you can test osx PR I did.

@AenBleidd
Copy link
Member Author

It would be nice if you can test osx PR I did.

Please read carefully my response to that PR: #5103 (comment)

@talregev
Copy link
Contributor

I don't agree with you.

@AenBleidd
Copy link
Member Author

I don't agree with you.

This is not the correct place to discuss different PR.
If you want to discuss it - feel free to reach me on Discord.

@talregev
Copy link
Contributor

I will not reach you on Discord. You are not here for cooperation. You are here for block things, and if I insist, you will falsify me for everything for that.
You should change your attitude to me. other wise you will maintain boinc alone.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #5208 (2d2a89d) into master (ce1eab0) will increase coverage by 7.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5208      +/-   ##
============================================
+ Coverage      3.85%   10.87%   +7.01%     
- Complexity        0     1064    +1064     
============================================
  Files           174      279     +105     
  Lines         28169    35977    +7808     
  Branches       6920     8255    +1335     
============================================
+ Hits           1085     3911    +2826     
- Misses        27043    31674    +4631     
- Partials         41      392     +351

see 105 files with indirect coverage changes

@AenBleidd AenBleidd removed the request for review from talregev April 27, 2023 18:41
@AenBleidd AenBleidd merged commit ef142df into BOINC:master Apr 27, 2023
@AenBleidd AenBleidd deleted the vko_fix_android branch April 27, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AenBleidd AenBleidd

Labels
C: Build System P: Major PR: Review required T: Bugfix
Projects
None yet
Milestone
Client/Manager 7.22.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AenBleidd @talregev