Fix screensaver crash bug introduced in PR #5197 commit 689a6eae25 #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AenBleidd
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 689a6ea changed the variable from a signed variable (
int) to unsigned (size_t), effectively causing an infiniteforloop.I believe this crash bug also affects MS Windows. I don't know whether this code is used for the X11 screensaver, but if so that will also be affected.
Once this is merged, it should be cherry-picked into the 7.22 branch so that we can build BOINC 7.22.2 for all platforms. I will next create another PR to improve backtrace generation on the Mac, which should also be included in BOINC 7.22.2.