-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: the default value for the "suspend_if_no_recent_input" pref should to 0, not 60 #5251
Conversation
…hould to 0, not 60! Otherwise BOINC will stop computing after 60 minutes of idleness. BTW, this should be called "suspend_if_no_recent_input_min" (times are in seconds unless otherwise specified)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5251 +/- ##
============================================
- Coverage 10.87% 10.86% -0.01%
Complexity 1064 1064
============================================
Files 279 279
Lines 35977 35969 -8
Branches 8255 8275 +20
============================================
- Hits 3911 3909 -2
+ Misses 31674 31668 -6
Partials 392 392
|
That change was introduced as part of the mass revision of preferences in #4871 - specifically, by commit 7d24c02. Since that PR was the primary driver for the v7.22 release cycle, we should probably ask testers to be especially vigilant for other unforced errors in previously-working areas of the client. |
I know where it was introduced. |
Exactly. That's why we need to check for 'errors like that' during user testing. |
Isn't the default also for the checkbox to be off for that option? If so, then the value for the number of seconds doesn't matter, because it won't be used. |
Assuming that the checkbox is off by default, a value of 60 minutes seems like a reasonable default for that field since it will be ignored unless the user turns the checkbox on. It makes no sense to have the default be 0 when the user sets the checkbox on, as then setting the checkbox on would have no effect until the user also changed the numeric value. |
If there is no global_prefs.xml or global_prefs_override.xml file, That's without the Manager. I'm not sure that what the Manager is doing is correct either, |
@davidpanderson, converted to 'Draft'. Please press 'Ready for review' button when it's ready for review :) |
@davidpanderson When a user attaches to their first project, doesn't it get their web preferences and then create the global_prefs.xml? If so, then the situation you describe can't happen once they get their first tasks from the project. |
When you create an account on a project, it initially doesn't have any global prefs. |
…itial value is 60
I see my mistake; I initialized it to 60 in defaults() rather than enabled_defaults(). |
Doesn't it have the web prefs defaults? Also, I seem to remember that at least some of the projects take you to their web page to set up your prefs as soon as yo attach, but i could be wrong. In any case, if we need to build 7.22.3, I won't be able to do that until after I return from my trip on June 3. |
Otherwise BOINC will stop computing after 60 minutes of idleness.
Is this a show-stopper? Quite possibly.
BTW, this should have been called "suspend_if_no_recent_input_min" (times are in seconds unless otherwise specified)